Detect React-Native environment and use all websocket features #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React-Native provides a Websocket object that is more functionally aligned with the Node.js websocket than the browser websocket. It has the same constructor signature as the Node.js websocket and can support extraHeaders and protocols. This PR will detect when the engine.io-client is running in React-Native, call the proper Websocket constructor, and enable support for extraHeaders.
|
Most of the travis build jobs passed. As best I can tell, the ones that failed don't seem to have failed due to the code changes in this PR |
|
Thanks 👍 |
darrachequesne
pushed a commit
that referenced
this pull request
Nov 2, 2018
…#591) React-Native provides a Websocket object that is more functionally aligned with the Node.js websocket than the browser websocket. It has the same constructor signature as the Node.js websocket and can support extraHeaders and protocols. This PR will detect when the engine.io-client is running in React-Native, call the proper Websocket constructor, and enable support for extraHeaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React-Native provides a Websocket object that is more functionally aligned with the Node.js websocket than the browser websocket.
It has the same constructor signature as the Node.js websocket and can support extraHeaders and protocols.
This PR will detect when the engine.io-client is running in React-Native, call the proper Websocket constructor, and enable support for extraHeaders.
Note: the
engine.io.jsfile is the generated output ofmake engine.io.js, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
When running engine.io-client in a React-Native environment, the websocket transport cannot use extraHeaders.
New behaviour
When running engine.io-client in a React-Native environment, the websocket transport can use extraHeaders
Other information (e.g. related issues)