Fix #603 Trigger xhr polling transport unload handler on pagehide or unload #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of beforeunload to prevent broke connection on cancelled beforeunload event
The kind of change this PR does introduce
Current behaviour
Polling transport breaks every time after
beforeunload
triggered, even if page wasn't closed after event have have has handed.See #603
New behaviour
Trigger xhr polling transport unload handler on
pagehide
orunload
instead ofbeforeunload
to prevent broke connection on cancelled beforeunload event.