Fix #603 Trigger xhr polling transport unload handler on pagehide or unload #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of beforeunload to prevent broke connection on cancelled beforeunload event
| @@ -401,7 +401,8 @@ if (typeof document !== 'undefined') { | |||
| if (typeof attachEvent === 'function') { | |||
| attachEvent('onunload', unloadHandler); | |||
| } else if (typeof addEventListener === 'function') { | |||
| addEventListener('beforeunload', unloadHandler, false); | |||
| var terminationEvent = 'onpagehide' in self ? 'pagehide' : 'unload'; | |||
There was a problem hiding this comment.
@SQReder Could you please explain what motivates the change from beforeunload to unload?
Edit: oh ok, didn't see #603 (comment)
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of beforeunload to prevent broke connection on cancelled beforeunload event
The kind of change this PR does introduce
Current behaviour
Polling transport breaks every time after
beforeunloadtriggered, even if page wasn't closed after event have have has handed.See #603
New behaviour
Trigger xhr polling transport unload handler on
pagehideorunloadinstead ofbeforeunloadto prevent broke connection on cancelled beforeunload event.