Add main minified dist file as exportable asset #682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the
engine.io.js
file is the generated output ofmake engine.io.js
, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
With the recent introduction of the exports block to package.json, modern node limits the files which can be imported from the module. Previously it was possible to import the main dist file directly. Now with the introduction of the exports block one receives an error trying to import the
engine.io.min.js
file:[ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/engine.io.min.js' is not defined by "exports"
Proposal to add at least the minified file to be exportable.
New behaviour
Does not introduce new behaviour, restores old one where it was possible to import any file from the package as there was no exports block on the package level defined - thus node allowed to export any file.
Other information (e.g. related issues)
The complete file list could be expanded to all the .js files listed in
./dist
in case any other file is consumed directly.