[fix] Undeterministic error in polling buffer processing

socketio · Sep 1, 2017 · dcd7b54 · dcd7b54
1 parent e76e035
commit dcd7b54
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/transports/polling.js b/lib/transports/polling.js
@@ -140,11 +140,10 @@ Polling.prototype.onDataRequest = function (req, res) {
   var self = this;
 
   function cleanup () {
-    chunks = isBinary ? new Buffer(0) : '';
     req.removeListener('data', onData);
     req.removeListener('end', onEnd);
     req.removeListener('close', onClose);
-    self.dataReq = self.dataRes = null;
+    self.dataReq = self.dataRes = chunks = null;
   }
 
   function onClose () {
@@ -163,7 +162,7 @@ Polling.prototype.onDataRequest = function (req, res) {
     }
 
     if (contentLength > self.maxHttpBufferSize) {
-      chunks = '';
+      chunks = isBinary ? new Buffer(0) : '';
       req.connection.destroy();
     }
   }