Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Processing error code on abort connection #562

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

shapel
Copy link
Contributor

@shapel shapel commented Sep 27, 2018

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

When you use allowRequest and pass error as number (like internal Server.errorMessages but in other range) system throw TypeError exception.

New behaviour

System will cat to string in any case.

Other information (e.g. related issues)

@shapel
Copy link
Contributor Author

shapel commented Sep 27, 2018

#561

@darrachequesne darrachequesne merged commit bc7b239 into socketio:master Nov 2, 2018
@darrachequesne
Copy link
Member

@shapel thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants