Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not necessarily meant to merged but rather to continue the conversation with code rather than speculating and ghosting on issues. I believe a lot of us are waiting on some type of answer and personally, switching to
ws
as the background WebSocket engine is not an acceptable performance loss.The kind of change this PR does introduce
Current behaviour
uws
is no longer maintainedNew behaviour
Migrate to
uWebSockets.js
- the latest iteration ofuws
for the Node ecosystem.Other information (e.g. related issues)
#578
#575
#560
socketio/socket.io#3342
The internet