-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing slash in path #297
Comments
No this isn't a regression. Paths are required to add a trailing / |
I guess I can add a check and add one if it's missing |
It is a regression (something that used to work, that doesn't anymore), but I guess it is a regression by design. Which is fine, as long as the behaviour is documented. |
This breaks some setups for example when we use the mattermost API. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a regression in b67b6ab where the
.Path
option is interpreted differently before and after the commit in question. Before b67b6ab, a path of/some/path
would makecreateURLs()
return e.g polling urlhttps://example.com:443/some/path/?transport=polling&b64=1
, but after it returnshttps://example.com:443/some/path?transport=polling&b64=1
. Note the slash between the path and the query string!I guess this is a regression, since it worked before, and don't any more. Also, on the server side, the server is created without the explicit slash in the path parameter. Adding a slash to the path parameter fixes the issue.
The text was updated successfully, but these errors were encountered: