-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing slash in path #1550
Comments
I am having the same issue as well |
Hi! The trailing slash is added there: https://github.com/socketio/engine.io-client/blob/dfee8ded722a8c4f9f773505d0c77b4561569863/lib/socket.ts#L335 (initial commit from 2012: socketio/engine.io-client@93605fd) I guess we could add an option to include it or not. Could you please explain your use case? |
if that will be optional in the settings that will be good |
The "addTrailingSlash" option allows to control whether a trailing slash is added to the path of the HTTP requests created by the library: - true (default): "/engine.io/" - false: "/engine.io" Related: socketio/socket.io-client#1550 Signed-off-by: iifawzi <iifawzie@gmail.com>
ping |
The option is already added at socketio/engine.io-client@21a6e12 |
Update: the import { io } from "socket.io-client";
const socket = io("https://example.com", {
addTrailingSlash: false
}); Reference: https://socket.io/docs/v4/client-options/#addtrailingslash Please reopen if needed! |
Following issue: When I use another domain (which is different than my current domain) for example
Everything seems to be working so far, but when I use my current domain as the host, it automatically removes the trailingSlash at the end and the result is this one and then it tries to add the trailing slash like this: That's how my configuration looks like:
|
Hi @necm1 , do you know which component returns the HTTP 308 response? nginx? The
|
I guess NextJS SSR seems to give me the HTTP 308 response (https://nextjs.org/docs/app/api-reference/next-config-js/trailingSlash). I'm using NextJS SSR rewrites as a proxy to my real NestJS backend. I just set Sorry for reopening this issue. I was just confused and thought that |
Describe the bug
Version - last stable
So basically i getting the same issue which was raised here in the swift client
socketio/socket.io-client-swift#297
if i want to use custom url path, i'm adding it to the options object like:
path: '/keka',
but in the request url getting
/keka/?
anyone manage this issue?
The text was updated successfully, but these errors were encountered: