-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Returns not unique id for cache connection #1225
Comments
5 tasks
darrachequesne
added a commit
that referenced
this issue
Feb 3, 2021
Previously, the following code: ```js const socket1 = io({ path: "/test1" }); const socket2 = io({ path: "/test2" }); ``` would result in one single Manager, with the "/test2" path being silently ignored. Two distinct Manager instances will now be created. Related: #1225
Fixed by 7a0c2b5. |
sunrise30
added a commit
to sunrise30/socket.io-client
that referenced
this issue
Jan 8, 2022
Previously, the following code: ```js const socket1 = io({ path: "/test1" }); const socket2 = io({ path: "/test2" }); ``` would result in one single Manager, with the "/test2" path being silently ignored. Two distinct Manager instances will now be created. Related: socketio/socket.io-client#1225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note: for support questions, please use one of these channels: stackoverflow or slack
You want to:
Current behaviour
Inability to work with two different socket servers and namespaces
Steps to reproduce (if the current behaviour is a bug)
Note: the best way to get a quick answer is to provide a failing test case, by forking the following fiddle for example.
Expected behaviour
console.log(socket2_with_nsp.io.opts.path === PATH_2); // true
Setup
Other information (e.g. stacktraces, related issues, suggestions how to fix)
Please, review my PR with the fix: #1224
The text was updated successfully, but these errors were encountered: