Disable AMD for json3 #1005
Merged
Disable AMD for json3 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saying to Webpack don't use the AMD style for json3 dependency
|
@davidmatas thanks for the report! Could you confirm that this is the only failing dependency? |
|
@darrachequesne Yes, in my tests this is the only one. I've tested a new build with the new webpack config and works fine. What about the CI failing check? It should not be related :/ |
|
@davidmatas no it's not related, iOS 7.1 is now deprecated. I'll remove it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying to Webpack don't use the AMD style for json3 dependency
Fix #1004