Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minified socket.io.min.js #1021

Merged
merged 2 commits into from
Nov 13, 2016
Merged

Support minified socket.io.min.js #1021

merged 2 commits into from
Nov 13, 2016

Conversation

bananaappletw
Copy link
Contributor

Support the functionality of generating minified socket.io.min.js.

The kind of change this PR does introduce

  • a new feature
  • an update to the documentation

Current behaviour

No minified socket.io.min.js.

New behaviour

After running make socket.io.js, minified socket.io.min.js is generated.

Other information (e.g. related issues)

None.

@bananaappletw
Copy link
Contributor Author

Sometimes the test will pass sometimes not.
Seems like timeout is too short for the test.
If the Travis ci's container is in good condition, the test will pass.
Else not.

@darrachequesne
Copy link
Member

I think it related to the node target, which now equals to node v7 (it's not related to the PR).

@bananaappletw
Copy link
Contributor Author

bananaappletw commented Nov 8, 2016

@darrachequesne
Not exactlly.
It's not related to PR.
Neither Node version.
Take a look of this one.
https://travis-ci.org/socketio/socket.io-client/builds/174189877
Test failed in Node 0.10

@bananaappletw
Copy link
Contributor Author

@darrachequesne
I think this test prove it.
It passed!

@bananaappletw
Copy link
Contributor Author

@darrachequesne
Any update here?

@darrachequesne darrachequesne merged commit 1f55bf2 into socketio:master Nov 13, 2016
@darrachequesne
Copy link
Member

@bananaappletw thanks!

@darrachequesne darrachequesne added this to the 1.6.0 milestone Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants