-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generated files to dist
folder
#1025
Conversation
@@ -1,7 +1,7 @@ | |||
|
|||
REPORTER = dot | |||
|
|||
build: socket.io.js socket.io.min.js | |||
build: socket.io.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate build
8e96181
to
b75e369
Compare
b75e369
to
cc6cb4f
Compare
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
@@ -12,7 +12,7 @@ | |||
|
|||
A standalone build of `socket.io-client` is exposed automatically by the | |||
socket.io server as `/socket.io/socket.io.js`. Alternatively you can | |||
serve the file `socket.io.js` or `socket.io.min.js` found at the root of this repository. | |||
serve the file `socket.io.js` or `socket.io.min.js` found in the `dist` folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the path of socket.io.min.js
was even documented I think this is a breaking change which was shipped in a minor release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that 😕
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
No description provided.