Move generated files to dist folder
#1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrachequesne
commented
Nov 17, 2016
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| REPORTER = dot | |||
|
|
|||
| build: socket.io.js socket.io.min.js | |||
| build: socket.io.js | |||
darrachequesne
force-pushed
the
use-dist
branch
from
8e96181
to
b75e369
Compare
darrachequesne
force-pushed
the
use-dist
branch
from
b75e369
to
cc6cb4f
Compare
darrachequesne
added a commit
to darrachequesne/socket.io
that referenced
this pull request
Nov 27, 2016
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
darrachequesne
added a commit
to socketio/socket.io
that referenced
this pull request
Nov 27, 2016
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
lo1tuma
reviewed
Nov 29, 2016
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| A standalone build of `socket.io-client` is exposed automatically by the | |||
| socket.io server as `/socket.io/socket.io.js`. Alternatively you can | |||
| serve the file `socket.io.js` or `socket.io.min.js` found at the root of this repository. | |||
| serve the file `socket.io.js` or `socket.io.min.js` found in the `dist` folder. | |||
There was a problem hiding this comment.
As the path of socket.io.min.js was even documented I think this is a breaking change which was shipped in a minor release.
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Following socketio/socket.io-client#1025, the output files are now generated in the dist directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.