Add nsp prefix to socket.id #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
bot-linagora
pushed a commit
to linagora/openpaas-esn
that referenced
this pull request
Sep 18, 2019
io.of(namespace).sockets will be an object instead of array the id of connection on client side in the new version is appended by a namespace prefix. Take a look at: socketio/socket.io-client#1058
This was referenced May 29, 2021
This was referenced Jun 6, 2021
1 task
This was referenced Jul 5, 2021
Closed
1 task
1 task
1 task
1 task
1 task
This was referenced Feb 4, 2022
Closed
1 task
1 task
1 task
This was referenced Jun 27, 2022
1 task
1 task
This was referenced Nov 20, 2022
1 task
1 task
1 task
Closed
1 task
Closed
1 task
Closed
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #959
Currently, the socket.id for a non-default namespace is different on the server / on the client (
e9232khon the client, no matter which namespace, but/<nsp>#e9232khon the server). That commit fixes that.Related: https://github.com/socketio/socket.io/pull/2509/files