Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new io.Manager(...) returns Manager #1093

Merged
merged 1 commit into from
Mar 18, 2017
Merged

new io.Manager(...) returns Manager #1093

merged 1 commit into from
Mar 18, 2017

Conversation

swhgoon
Copy link
Contributor

@swhgoon swhgoon commented Mar 16, 2017 •
edited
Loading

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • typo

Current behaviour

New behaviour

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit 2135ed8 into socketio:master Mar 18, 2017
@darrachequesne
Copy link
Member

Thanks!

@swhgoon swhgoon deleted the patch-1 branch March 19, 2017 03:55
@darrachequesne darrachequesne added this to the 2.0.0 milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@swhgoon @darrachequesne