Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependency] Downgrade to base64-arraybuffer@0.1.4 (#1234) #1235

Closed
wants to merge 1 commit into from

Conversation

aleen42
Copy link

@aleen42 aleen42 commented Sep 20, 2018

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix

Current behaviour

Bug mentioned in #1234 will happen under IE8

New behaviour

Bug mentioned in #1234 won't happen under IE8

@aleen42
Copy link
Author

aleen42 commented Jul 30, 2020

Any progress?

@darrachequesne
Copy link
Member

The base64-arraybuffer was included by a nested dependency (engine.io-parser). Closed by socketio/engine.io-parser@11e9563

@darrachequesne darrachequesne added this to the 2.3.1 milestone Sep 30, 2020
@darrachequesne
Copy link
Member

base64-arraybuffer@0.1.4 was included in release 2.3.1.

@aleen42 should this change be backported to an previous release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants