Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to specify a sessionid when connecting. #497

Closed
mthomas opened this issue Aug 30, 2011 · 1 comment
Closed

Allow clients to specify a sessionid when connecting. #497

mthomas opened this issue Aug 30, 2011 · 1 comment
Labels
enhancement New feature or request

Comments

@mthomas
Copy link

mthomas commented Aug 30, 2011

This is a proposal for new functionality.

The intended use case is to allow clients to reconnect using the same sessionid that they originally connected with. This, combined with the RedisStore would allow a socket server to fall out of a cluster, a client to reconnect to another server in the cluster, all while maintaining data associated with the socket.

My proposal would be to modify the Manager.handleHandshake method to pull a sessionid from the query if it exists.

In order to utilize this feature, clients would have to set the sessoinid in the socket.options.query (client).

Any thoughts?

I'll submit a pull request including a new test for your consideration!

@mthomas
Copy link
Author

mthomas commented Aug 30, 2011

Pull request including new functionality+test: #498

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant