Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws affected by a DoS when handling a request with many HTTP headers #5049

Closed
NormandoHall opened this issue Jun 18, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@NormandoHall
Copy link

GHSA-3h5v-q93c-6h6q

@NormandoHall NormandoHall added the to triage Waiting to be triaged by a member of the team label Jun 18, 2024
@darrachequesne
Copy link
Member

We have released some new versions which include the ws fix:

Thanks for the heads-up!

@darrachequesne darrachequesne added bug Something isn't working and removed to triage Waiting to be triaged by a member of the team labels Jun 18, 2024
@miszczu-drako
Copy link

how about socket.io-adapter? is it maintained by your team also?

When I run npm audit I still see affected ws version
npm audit --audit-level=high --package-lock-only --omit=dev --omit=optional

npm audit report

ws 8.0.0 - 8.17.0
Severity: high
ws affected by a DoS when handling a request with many HTTP headers - GHSA-3h5v-q93c-6h6q
fix available via npm audit fix --force
Will install socket.io@4.5.4, which is a breaking change
node_modules/socket.io-adapter/node_modules/ws
socket.io-adapter >=2.5.2
Depends on vulnerable versions of ws
node_modules/socket.io-adapter
socket.io >=4.6.0-alpha1
Depends on vulnerable versions of socket.io-adapter
node_modules/socket.io

3 high severity vulnerabilities

@miszczu-drako
Copy link

Just in case I have raised #5051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants