Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5049 didn't fix ws for socket.io-adapter #5051

Closed
miszczu-drako opened this issue Jun 18, 2024 · 3 comments
Closed

Issue #5049 didn't fix ws for socket.io-adapter #5051

miszczu-drako opened this issue Jun 18, 2024 · 3 comments
Labels
to triage Waiting to be triaged by a member of the team

Comments

@miszczu-drako
Copy link

npm audit --audit-level=high --package-lock-only --omit=dev --omit=optional

npm audit report
ws 8.0.0 - 8.17.0
Severity: high
ws affected by a DoS when handling a request with many HTTP headers - GHSA-3h5v-q93c-6h6q
fix available via npm audit fix --force
Will install socket.io@4.5.4, which is a breaking change
node_modules/socket.io-adapter/node_modules/ws
socket.io-adapter >=2.5.2
Depends on vulnerable versions of ws
node_modules/socket.io-adapter
socket.io >=4.6.0-alpha1
Depends on vulnerable versions of socket.io-adapter
node_modules/socket.io

3 high severity vulnerabilities

@sordu
Copy link
Contributor

sordu commented Jun 18, 2024

npm update socket.io-adapter
and
npm update engine.io

bumps ws in both and resolves the CVE on my local machine

@darrachequesne
Copy link
Member

This should be fixed by socketio/socket.io-adapter@93fe190, included in socket.io-adapter@2.5.5.

@miszczu-drako could you please check?

@miszczu-drako
Copy link
Author

yes, no more vulnerabilities found. Thanks a lot for a quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage Waiting to be triaged by a member of the team
Projects
None yet
Development

No branches or pull requests

3 participants