Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking call to crypto.randomBytes #934

Closed
siddMahen opened this issue Jun 29, 2012 · 1 comment
Closed

Blocking call to crypto.randomBytes #934

siddMahen opened this issue Jun 29, 2012 · 1 comment

Comments

@siddMahen
Copy link

It seems to me that https://github.com/LearnBoost/socket.io/blob/master/lib/manager.js#L713 is a sync call. Is crypto level randomness really necessary to generate sessionIds?
@edwardmsmith
Copy link

As to "Is crypto level randomness really necessary to generate sessionIds?", see #856

darrachequesne pushed a commit that referenced this issue Jul 4, 2024
@nkzawa
Merge pull request #934 from darrachequesne/patch-2
7dd672f 
Add badges showing dependency status
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardmsmith @siddMahen