Allow further configurability of reconnect: add option maxReconnectionDelay #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized tests
Simplified chat example to take advantage of JSON encoding/decoding Removed fs sync call from example
…connection attempt. Thanks @steadicat from swarmation
…nicokaiser) Added origin verification for incoming data.
…eSafari (fixes #29 and potentially creationix issue)
Added clientsIndex reference for BC
…t.github.com/615009 for uncaptured 'timeout' errors.
The fix for it is not as elegant as I would have hoped but it does the job, preventing un-needed listeners to be added on the connections.
…o tifroz-master
… on from the pull request
|
On second thought I could probably use Number.POSITIVE_INFINITY for maxReconnectionAttempts which would make commit 419e559 obsolete, thoughts on that? |
This was referenced Jan 9, 2023
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often desirable to not go beyond a certain point when exponentially scaling the reconnection delay especially when working with a high number of reconnection attempts. For most applications the reconnectionDelay becomes too large when it exeeds a day or so, quite a lot will want a lower delay.
I added an option "maxReconnectionDelay" which caps the reconnection delay to the configured value. The default value is -1 which means no limit.
I also added the possible value -1 to maxReconnectionAttempts meaning unlimited reconnection attempts which works nicely with capping the reconnection delay.