-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of a custom parser #2829
Merged
darrachequesne
merged 1 commit into
socketio:master
from
darrachequesne:feature/custom-parser
Jan 24, 2017
Merged
Allow the use of a custom parser #2829
darrachequesne
merged 1 commit into
socketio:master
from
darrachequesne:feature/custom-parser
Jan 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2017
darrachequesne
pushed a commit
to darrachequesne/socket.io-adapter
that referenced
this pull request
Feb 16, 2017
That will allow to use a custom parser (see socketio/socket.io#2829).
darrachequesne
added a commit
to socketio/socket.io-adapter
that referenced
this pull request
Feb 16, 2017
That will allow to use a custom parser (see socketio/socket.io#2829).
darrachequesne
pushed a commit
to darrachequesne/socket.io-client
that referenced
this pull request
Feb 17, 2017
darrachequesne
added a commit
to darrachequesne/socket.io-client
that referenced
this pull request
Feb 20, 2017
darrachequesne
added a commit
to socketio/socket.io-client
that referenced
this pull request
Feb 20, 2017
enderson-pan
pushed a commit
to holytiny/feathersjs-wxmp-socket.io-client
that referenced
this pull request
Nov 1, 2019
Closed
sunrise30
added a commit
to sunrise30/socket.io-client
that referenced
this pull request
Jan 8, 2022
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
New behaviour
This would enable the use of some custom parsers, like the following based on msgpack:
And then:
That would also provide a workaround for socketio/socket.io-parser#61.
Related: #1652 #1946
Note: that would need to update
socket.io-client
andsocket.io-adapter
too.