Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Touch Support #3104

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

nadirlaskar
Copy link
Contributor

@nadirlaskar nadirlaskar commented Nov 2, 2017

Added support for touch to the whiteboard example.

The kind of change this PR does introduce

  • a bug fix

Current behavior

Touch is not working on the whiteboard example

New behavior

Added support for touch in whiteboard example

Other information (e.g. related issues)

Added support for touch to the whiteboard example.
Updated the file and fixing the typo  on `touchcancel` event.
Copy link
Contributor Author

@nadirlaskar nadirlaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the event name typo.

examples/whiteboard/public/main.js Show resolved Hide resolved
examples/whiteboard/public/main.js Outdated Show resolved Hide resolved
@darrachequesne darrachequesne changed the base branch from master to develop November 20, 2018 07:00
@darrachequesne darrachequesne merged commit d3c653d into socketio:develop Nov 20, 2018
@darrachequesne
Copy link
Member

Great, thanks!

@nadirlaskar nadirlaskar deleted the touch-support-patch branch August 7, 2020 12:56
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants