Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #3410

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Update package.json #3410

merged 1 commit into from
Mar 15, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Feb 28, 2019

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Use master License: https://github.com/socketio/socket.io/blob/master/LICENSE

@bodorjzsolt
Copy link

I am planning to use previous versions, does MIT License applies to older version also?

@grant
Copy link
Contributor Author

grant commented Feb 28, 2019

No. The project states BSD for the previous version and this changes it to MIT.
I do not maintain this projects, so please contact the maintainer for further questions.

@bodorjzsolt
Copy link

Could you say what BSD was it exactly?

@grant
Copy link
Contributor Author

grant commented Feb 28, 2019

Please ask the maintainer of this project, not me anymore. I don't have permissions for this project.

@grant
Copy link
Contributor Author

grant commented Mar 15, 2019

@darrachequesne Can you look at this?

@darrachequesne darrachequesne merged commit 9c1e73c into socketio:master Mar 15, 2019
@darrachequesne
Copy link
Member

LGTM 👍

@grant grant deleted the patch-1 branch March 15, 2019 21:23
@WioSwitch
Copy link

🍎🍎🍎🍎🍎

@darrachequesne darrachequesne added this to the 2.3.0 milestone Sep 28, 2020
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
There was no obvious reason to use BSD instead of MIT for that very basic chat app.

Closes socketio#3411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants