fix: fix race conditions with dynamic namespaces (#4136) #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed the test a bit so that it does not rely on |
darrachequesne
pushed a commit
that referenced
this pull request
Oct 24, 2021
Using an async operation with `io.use()` could lead to the creation of
several instances of a same namespace, each of them overriding the
previous one.
Example:
```js
io.use(async (nsp, auth, next) => {
await anOperationThatTakesSomeTime();
next();
});
```
Related: #4136
|
Merged as 9d86397. Thanks! |
|
@darrachequesne Quick question: are you planning on releasing this as 4.3.2? I'm currently monkey-patching socket.io in my codebase, so it would be nice to be able to drop the patch! |
|
Let's do this! https://github.com/socketio/socket.io/releases/tag/4.3.2 |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Using an async operation with `io.use()` could lead to the creation of
several instances of a same namespace, each of them overriding the
previous one.
Example:
```js
io.use(async (nsp, auth, next) => {
await anOperationThatTakesSomeTime();
next();
});
```
Related: socketio#4136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
A race condition exists when creating dynamic namespaces (see #4136)
New behavior
The race condition is fixed.