Fix reconnection handling in the chat demo app #4189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
The source code of the example app
examples/chat
implies that reconnetion status (failure or success) is shown to the user.In fact, it's not, because the reconnection events are listened to incorrectly: you're supposed to listen to the Manager's events like
socket.io.on(...)
, not justsocket.on(...)
.I only wanted to take a look at how to handle disconnections and do reconnections, but here is what it came down to :)
New behavior
The example works as it's supposed to, you can now see messages like "attempt to reconnect has failed" in the UI.
Other information (e.g. related issues)
Also updated README in the example: it says you need to run
npm ci
to install packages, but since lockfiles are gitignored in theexample
folder, you actually need to runnpm i