Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to in-monorepo package versions #5168

Closed
wants to merge 1 commit into from

Conversation

jokester
Copy link
Contributor

@jokester jokester commented Aug 12, 2024

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

socket.io uses npm version of engine.io, not the version in repo. So is socket.io-client using npm engine.io-client.

IMHO this is not really making full use of monorepo .

New behavior

Latest in-tree version used. npm list now shows:

├─┬ socket.io@4.7.5 -> ./packages/socket.io
│ ├── accepts@1.3.8 deduped
│ ├── base64id@2.0.0 deduped
│ ├── cors@2.8.5 deduped
│ ├── debug@4.3.5 deduped
│ ├── engine.io@6.6.0 deduped -> ./packages/engine.io                    # change
│ ├── socket.io-adapter@2.5.5 deduped -> ./packages/socket.io-adapter
│ └── socket.io-parser@4.2.4 deduped -> ./packages/socket.io-parser

Other information (e.g. related issues)

Related to #5161

@jokester
Copy link
Contributor Author

The CI fail in https://github.com/socketio/socket.io/actions/runs/10353026589/job/28654936017 could be a random error, it says listen EADDRINUSE: address already in use :::49794

But I can't trigger a rerun.

@jokester
Copy link
Contributor Author

I think in npm monorepo with a package A and its depender B, the version of A must match its depender's package.json , for npm to link local A instead of downloading from npm.

This is unlike pnpm / yarn who supports version spec like workspace:~: pnpm ref

@darrachequesne
Copy link
Member

Merged as d5b22f5 and 5d9a2d5. I've split the change into two commits so it's easier to generate the changelog of each package.

Thanks a lot 👍

@jokester jokester deleted the link-monorepo-version branch August 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants