remove prettier v2 #5169
Merged
remove prettier v2 #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokester
commented
Aug 12, 2024
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "name": "socket.io", | |||
There was a problem hiding this comment.
This change makes package-lock.json to contain a stable root package name (otherwise it uses the directory name)
jokester
commented
Aug 12, 2024
.prettierrc.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "trailingComma": "es5" | |||
There was a problem hiding this comment.
I don't have strong preference on prettier config. It's just this options creates fewer diffs.
jokester
force-pushed
the
fix-prettier-version
branch
from
5df244e
to
883143c
Compare
darrachequesne
force-pushed
the
fix-prettier-version
branch
from
883143c
to
66b2cf6
Compare
|
@jokester thanks a lot 👍 I've removed the custom configuration, because I think the main purpose of prettier is to be opinionated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
2 versions of prettier, respectively v2 and v3, get installed.
New behavior
Only use prettier v3
Other information (e.g. related issues)