Support for inline (same port) flash socket policy request #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server is not run with root privileges, then the flashsocket transport will instead listen to all new connections on the main port for policy requests. Flash policy requests happen to both port 843 and the destination port: http://www.lightsphere.com/dev/articles/flash_socket_policy.html
|
Good stuff! Will merge asap |
|
I would say remove the if (netserver == null) { statement so the line flash socket policy can be used as backup for when for some reason the netServer fails to respond to a client. |
|
Hehe. I added that so that it would be a more palatable pull request since with the check it doesn't affect the current default behavior. I'm all for removing it. |
This was referenced Jan 8, 2021
darrachequesne
added a commit
that referenced
this pull request
Jul 4, 2024
ArrayBuffer.isView method is not defined in IE10.
darrachequesne
added a commit
that referenced
this pull request
Jul 8, 2024
darrachequesne
added a commit
that referenced
this pull request
Jul 8, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring that the server be run as root is generally considered a bad idea. This change listens on the target port for flash policy requests if the listener can't be started on port 843 (i.e. not root priveleged) and so it allows the flashsocket mode to work without root privelege.
I also suggest reversing the warning so that running as root produces a warning instead. Or perhaps having a (different) warning for both.