Fix for ID generation vulnerability #856 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
added a commit
that referenced
this pull request
Apr 26, 2012
Fix for ID generation vulnerability #856
|
Thanks a lot @martinthomson. This has been long overdue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using crypto.randomBytes to generate a session ID. 96 bits of randomness, 24 bits of sequence number. Using the URL safe base64 encoding RFC 4648 to represent the value.
Backward compatibility for node 0.4 uses an insecure generation method with Math.random(). I could fix this too, but I don't believe that this version of node is still popular enough to justify the effort.