Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix java 8 compatibility #292

Merged
merged 1 commit into from
Apr 2, 2023
Merged

fix java 8 compatibility #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ jobs:

steps:
- uses: actions/checkout@v3

- name: set JAVA_HOME
if: |
startsWith(matrix.ruby, 'jruby')
shell: bash
run: |
echo JAVA_HOME=$JAVA_HOME_11_X64 >> $GITHUB_ENV

- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{matrix.ruby}}
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ end

group :development, :test do
gem "coveralls", require: false
gem "rake-compiler", require: false
gem "rake-compiler", "~> 1.1.9", require: false
gem "rspec", "~> 3.7", require: false
gem "rubocop", "0.82.0", require: false
end
3 changes: 1 addition & 2 deletions rakelib/extension.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ if defined? JRUBY_VERSION
require "rake/javaextensiontask"
Rake::JavaExtensionTask.new("nio4r_ext") do |ext|
ext.ext_dir = "ext/nio4r"
ext.source_version = "1.8"
ext.target_version = "1.8"
ext.release = '8'
end
else
require "rake/extensiontask"
Expand Down