Fix conversion loses int precision #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #298
Getting this error on
gem install nio4r
using an Apple M1 computer with Ruby 3.0.6The value of a
long
type is being assigned to anint
type, which may result in the loss of data. By casting thebytes_read
andbytes_written
variable to anint
type, this will ensure that thebytes_read
andbytes_written
value is truncated to fit in the range of anint
type, and prevent any loss of data, which fixes this error.Locally, I was able to install this gem on my Apple M1 with Ruby 3.0.6 with these changes.
I'm not a C programmer, so please scrutinize.
Types of Changes
Contribution