New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue loading both nio and nio4r gems #302

Merged

ioquatix merged 1 commit into socketry:main from iterateNZ:conflict-with-nio-gem

Aug 12, 2023

Contributor

iterateNZ commented Aug 11, 2023 •

edited

Loading

I've got an older application that uses the nio gem https://rubygems.org/gems/nio.

While updating to use puma I hit uninitialized constant NIO (NameError) as an error as the Nio constant is loaded first.

This change allows loading nio4r explicitly.

gem 'nio', '~> 0.2.5'
gem 'nio4r', require: 'nio4r'
gem 'puma'


          Resolve issue loading both nio and nio4r gems

08552c0

Member

ioquatix commented Aug 11, 2023

This seems reasonable to me.

ioquatix enabled auto-merge (squash)

August 12, 2023 03:13

ioquatix approved these changes

View reviewed changes

ioquatix merged commit d9682cf into socketry:main

30 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet