Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license #309

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Fix license #309

merged 2 commits into from
Nov 25, 2023

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Nov 24, 2023

Add libev licenses (BSD-2-Clause OR GPL-2.0-or-later) into gem metadata.

Types of Changes

  • Maintenance.

Contribution

And use SPDX identifiers.

Signed-off-by: Vít Ondruch <vondruch@redhat.com>
The gem ships not just MIT licensed code but also bundles libev, with
disctinc 'BSD-2-Clause OR GPL-2.0-or-later' license. Don't hide this
information.

Signed-off-by: Vít Ondruch <vondruch@redhat.com>
@ioquatix ioquatix merged commit aeb9ef6 into socketry:main Nov 25, 2023
@ioquatix
Copy link
Member

Thanks ☺️

@viktorianer
Copy link

@voxik
Just trying to understand this PR, as it breaks my pipeline.

The gem nio4r uses libev, which was distributed under the BSD license. But, this fact was not reflected in nio4r gem metadata, since it was added in 15cab7a, 2011?

My pipeline checks dependencies for license and decisions, using https://rubygems.org/gems/license_finder. And before this change MIT was permitted, but now the nio4r license is different.

Also, as I understand, libev is not used in all cases?

Thank you for clarifications.

@voxik
Copy link
Contributor Author

voxik commented Jan 2, 2024

The gem nio4r uses libev, which was distributed under the BSD license. But, this fact was not reflected in nio4r gem metadata, since it was added in 15cab7a, 2011?

Right

Also, as I understand, libev is not used in all cases?

Not expert, but I assume that if you use NIO4R_PURE=true env variable, then libev is not used. Nonetheless, it is still installed.

@viktorianer
Copy link

@voxik
Ok, thanks for these clarifications.

Could you please change the licenses spec to an array, as it is documented in Ruby gem specification reference?
https://guides.rubygems.org/specification-reference/#licenses=

Because, using one string with multiple licenses is not distinguishable for automated processes, like license_finder.

So, it should be: spec.license ["MIT", "BSD-2-Clause", "GPL-2.0-or-later"]

Thank you in advance.

voxik added a commit to voxik/nio4r that referenced this pull request Jan 4, 2024
RubyGems currently complains during gem build:

~~~
WARNING:  license value 'MIT AND (BSD-2-Clause OR GPL-2.0-or-later)' is invalid.  Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
Did you mean 'AGPL-1.0-or-later', 'AGPL-3.0-or-later', 'BSD-2-Clause-Patent', 'GPL-2.0-or-later', 'LGPL-2.0-or-later'?
~~~

Nothig else then plain list of license identifers is supported ATM.

Relates socketry#309
voxik added a commit to voxik/nio4r that referenced this pull request Jan 4, 2024
RubyGems currently complains during gem build:

~~~
WARNING:  license value 'MIT AND (BSD-2-Clause OR GPL-2.0-or-later)' is invalid.  Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
Did you mean 'AGPL-1.0-or-later', 'AGPL-3.0-or-later', 'BSD-2-Clause-Patent', 'GPL-2.0-or-later', 'LGPL-2.0-or-later'?
~~~

Nothing else then plain list of license identifers is supported ATM.

Relates socketry#309
voxik added a commit to voxik/nio4r that referenced this pull request Jan 4, 2024
RubyGems currently complain during gem build:

~~~
WARNING:  license value 'MIT AND (BSD-2-Clause OR GPL-2.0-or-later)' is invalid.  Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
Did you mean 'AGPL-1.0-or-later', 'AGPL-3.0-or-later', 'BSD-2-Clause-Patent', 'GPL-2.0-or-later', 'LGPL-2.0-or-later'?
~~~

Nothing else then plain list of license identifers is supported ATM.

Relates socketry#309
@voxik voxik mentioned this pull request Jan 4, 2024
2 tasks
ioquatix pushed a commit to voxik/nio4r that referenced this pull request Mar 20, 2024
RubyGems currently complain during gem build:

~~~
WARNING:  license value 'MIT AND (BSD-2-Clause OR GPL-2.0-or-later)' is invalid.  Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
Did you mean 'AGPL-1.0-or-later', 'AGPL-3.0-or-later', 'BSD-2-Clause-Patent', 'GPL-2.0-or-later', 'LGPL-2.0-or-later'?
~~~

Nothing else then plain list of license identifers is supported ATM.

Relates socketry#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants