Send correct status when info call fails

sockjs · Sep 18, 2023 · 0b2eefe · 0b2eefe
1 parent 2011ab1
commit 0b2eefe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/info-ajax.js b/lib/info-ajax.js
@@ -33,7 +33,7 @@ function InfoAjax(url, AjaxObject) {
         info = {};
       }
     }
-    self.emit('finish', info, rtt);
+    self.emit('finish', info, rtt, status);
     self.removeAllListeners();
   });
 }

diff --git a/lib/info-receiver.js b/lib/info-receiver.js
@@ -61,10 +61,10 @@ InfoReceiver.prototype.doXhr = function(baseUrl, urlInfo) {
     self.emit('finish');
   }, InfoReceiver.timeout);
 
-  this.xo.once('finish', function(info, rtt) {
+  this.xo.once('finish', function(info, rtt, status) {
     debug('finish', info, rtt);
     self._cleanup(true);
-    self.emit('finish', info, rtt);
+    self.emit('finish', info, rtt, status);
   });
 };
 

diff --git a/lib/main.js b/lib/main.js
@@ -173,11 +173,11 @@ SockJS.OPEN = 1;
 SockJS.CLOSING = 2;
 SockJS.CLOSED = 3;
 
-SockJS.prototype._receiveInfo = function(info, rtt) {
+SockJS.prototype._receiveInfo = function(info, rtt, status) {
   debug('_receiveInfo', rtt);
   this._ir = null;
   if (!info) {
-    this._close(1002, 'Cannot connect to server');
+    this._close(status || 1002, 'Cannot connect to server');
     return;
   }
 

diff --git a/tests/lib/end-to-end.js b/tests/lib/end-to-end.js
@@ -26,7 +26,7 @@ describe('End to End', function () {
         }
 
         try {
-          expect(e.code).to.equal(1002);
+          expect(e.code).to.equal(404);
           expect(e.reason).to.equal('Cannot connect to server');
           expect(e.wasClean).to.equal(false);
         } catch (err) {