Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using --directory to set protoc output path (Issue #177) #178

Closed
wants to merge 3 commits into from

Conversation

markdoerr
Copy link
Contributor

Here is a suggestion to fix the protoc _pb2 generation output path, using the --directory option.

This would solve #177 .

@legau
Copy link
Contributor

legau commented May 30, 2023

Hi,
I think you should also be able to define a different proto_path from the out options, with settings.BASE_DIR as default. As such the condition on https://github.com/socotecio/django-socio-grpc/pull/178/files#diff-54c9b4a9cdedf22408f568da5e1496b387cf7eb2841a7bd0671b8db8e2834ac9R117-R118 would be affected.
Thanks for your contribution

@markdoerr
Copy link
Contributor Author

Thanks, @legau, for your comment,
I agree - if I understood your comment correctly - and make a suggestion to solve it.

@markdoerr
Copy link
Contributor Author

@legau ,
I added the proto_path option.
Still need to test everything.

@AMontagu
Copy link
Collaborator

Hello @markdoerr

Can we close this PR ?

@AMontagu AMontagu closed this Nov 16, 2023
@AMontagu AMontagu reopened this Nov 16, 2023
@markdoerr
Copy link
Contributor Author

@AMontagu,
yes, I think, we can close it until we managed to finialise the examples ... sorry for all the delays :(

@markdoerr markdoerr closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants