Add Accuracy in time #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| acc_in_time = [] | ||
|
|
||
| for tau in taus: | ||
| mask_past_censored = (y_test["event"] == 0) & (y_test["duration"] < tau) |
There was a problem hiding this comment.
It seems to be y_test["duration"] <= tau in Eq 4 of the paper ?
| y_pred_at_t = y_pred[:, :, tau_idx] | ||
| y_pred_class = y_pred_at_t[~mask_past_censored, :].argmax(axis=1) | ||
|
|
||
| y_test_class = y_test["event"] * (y_test["duration"] < tau) |
Comment on lines
+45
to
+46
| tau_idx = np.searchsorted(times, tau) | ||
| y_pred_at_t = y_pred[:, :, tau_idx] |
There was a problem hiding this comment.
Is that okay if tau does not belong to times ? It's probably fine if times is sufficiently fine-grained. Perhaps we could interpolate.
| from hazardous.utils import check_y_survival | ||
|
|
||
|
|
||
| def accuracy_in_time(y_test, y_pred, times, quantiles=None, taus=None): |
There was a problem hiding this comment.
For the docstring, the math formula as was done for Brier score would be very nice for the API doc (even if it looks kind of aweful in the docstring).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #74
Need to document and add test