Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move server configuration parameter limits to constants #80

Closed
soda3x opened this issue Jul 13, 2024 · 2 comments
Closed

Move server configuration parameter limits to constants #80

soda3x opened this issue Jul 13, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0

Comments

@soda3x
Copy link
Owner

soda3x commented Jul 13, 2024

Currently when using "Default" objects, parameter bounds are not respected. These bounds should be added to a Constants static class and these Default objects should use the parameter minimums.
@soda3x soda3x added enhancement New feature or request good first issue Good for newcomers labels Jul 13, 2024
@soda3x
Copy link
Owner Author

soda3x commented Jul 13, 2024

The server parameter GUI elements can then also use these

@soda3x soda3x added this to the v1.0 milestone Aug 24, 2024
twicerain added a commit to twicerain/ArmaReforgerServerTool that referenced this issue Aug 25, 2024
@twicerain
soda3x#80: Move server configuration parameter limits and defaults to…
491bde5 
… class constants
twicerain added a commit to twicerain/ArmaReforgerServerTool that referenced this issue Aug 25, 2024
@twicerain
soda3x#80: Move Rcon permissions to class and use Default permission
a24b2e2
twicerain added a commit to twicerain/ArmaReforgerServerTool that referenced this issue Aug 25, 2024
@twicerain
soda3x#80: cleanup
50786f7
@twicerain twicerain mentioned this issue Aug 25, 2024
Merged
twicerain added a commit to twicerain/ArmaReforgerServerTool that referenced this issue Aug 25, 2024
@twicerain
soda3x#80: enhance readabliity and consistency
2020b27
@soda3x
Copy link
Owner Author

soda3x commented Aug 26, 2024

Implemented by @twicerain

@soda3x soda3x closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@soda3x