Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdsdock bug parsing vgs size due to locale-dependent number format #608

Closed
acorbellini opened this issue Feb 5, 2019 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@acorbellini
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:
VGS formats numbers depending on current locale. Causing osdsdock to incorrectly parse the free and total size of the volumes. E.g. in spanish locale VGS returns 24,00 while in US locale it returns 24.00
What you expected to happen:
I expected osdsctl pool list to show the correct size of the backend
How to reproduce it (as minimally and precisely as possible):
Follow the installation steps in the "OpenSDS Local Cluster with Multi tenants Installation" and set the locale in spanish (in my environment, ubuntu selects it as default!).

Anything else we need to know?:
The parsing of the volume size should be locale independent. If I change the locale to en_US, everything is fine. Thanks for the awesome work you do!
Environment:

  • Hotpot(release/branch) version: Bali
  • OS (e.g. from /etc/os-release): Ubuntu 16.04 with spanish locale (detected by default in the setup)
  • Kernel (e.g. uname -a): 4.15.0-29
  • Install tools: Followed the multitenant setup
  • Others:
@leonwanghui
Copy link
Collaborator

That's really funny, @xxwjj would be assigned to check on it.

@leonwanghui leonwanghui added the bug Something isn't working label Feb 11, 2019
@xxwjj
Copy link
Collaborator

xxwjj commented Feb 14, 2019

@acorbellini can you give me more detail infomation. BTW, how set the locale?

@leonwanghui
Copy link
Collaborator

@acorbellini Please take a look to see if #616 resolves this issue, thanks!

@leonwanghui
Copy link
Collaborator

I will close this issue considering it's already resolved, plz be free to reopen it if anything still goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants