Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the lvm driver, fixed some bugs #616

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

xxwjj
Copy link
Collaborator

@xxwjj xxwjj commented Feb 22, 2019

What this PR does / why we need it:

  1. Removed some un-used codes in lvm driver.
  2. Fixed two bugs: osdsdock bug parsing vgs size due to locale-dependent number format #608 Delete volume snapshot got an error #583
  3. Sine the lvm.go file is more and more complex, I separate it into two files: lvm.go cli.go.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 39.436% when pulling ed045cf on xxwjj:lvm_bugs into 3acb0c2 on opensds:development.

@leonwanghui leonwanghui added the patch there is minor code change label Feb 22, 2019
@leonwanghui leonwanghui added this to the Capri Milestone-2 milestone Feb 22, 2019
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit ba0beba into sodafoundation:development Feb 22, 2019
@xxwjj xxwjj deleted the lvm_bugs branch May 27, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch there is minor code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants