-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of Development Branch to Master branch for Daito RC2 Release #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update attachment API based on host management
Add Host API into swagger
Fileshare name supports upto 255 characters name length
Add host api validation and filtering
* Add Filters for DurableName for Volume Get API. * Add suport for ESXI osType for Host create API swagger.
Update GetVolume Filters and Add ESXI osType support for HOST API
* Fix profile api in swagger * Fix some typo based on comment
Integrate all the "select" function to a single one
Fix for fileshare mount issue
Modify oceanstor type string
Oceanstor configuration
kumarashit
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 34.73% 34.89% +0.16%
==========================================
Files 95 97 +2
Lines 17778 17576 -202
==========================================
- Hits 6175 6133 -42
+ Misses 10726 10574 -152
+ Partials 877 869 -8
|
wisererik
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Integration of Development Branch to Master branch for Daito RC2 Release. Planned release tag is v0.7.0-Daito-RC2
Which issue this PR fixes
-hotpot api updates for basic data provisioning
-host management apis initial version integrated
-updated to openapi 3.0
-hotpot api additional parameters added
-swagger validation added
Release note:
Basic Testing of Hotpot has been completed for all APIs (including host APIs)