Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the build and test script for ARM64 #1133

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ build: prebuild osdsdock osdslet osdsapiserver osdsctl metricexporter
prebuild:
mkdir -p $(BUILD_DIR)

.PHONY: osdsdock osdslet osdsapiserver osdsctl docker test protoc goimports
.PHONY: osdsdock osdslet osdsapiserver osdsctl docker docker.arm64 test protoc goimports

osdsdock:
go build -ldflags '-w -s' -o $(BUILD_DIR)/bin/osdsdock github.com/opensds/opensds/cmd/osdsdock
Expand All @@ -56,6 +56,14 @@ docker: build
docker build cmd/osdslet -t opensdsio/opensds-controller:latest
docker build cmd/osdsapiserver -t opensdsio/opensds-apiserver:latest

docker.arm64: build
cp $(BUILD_DIR)/bin/osdsdock ./cmd/osdsdock
cp $(BUILD_DIR)/bin/osdslet ./cmd/osdslet
cp $(BUILD_DIR)/bin/osdsapiserver ./cmd/osdsapiserver
docker build cmd/osdsdock -t opensdsio/opensds-dock-arm64:ci
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does ci mean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wisererik . I used ci tag to test on my machine ,and sorry for that . I have update it to latest. Please take a look, thanks!

docker build cmd/osdslet -t opensdsio/opensds-controller-arm64:ci
docker build cmd/osdsapiserver -t opensdsio/opensds-apiserver-arm64:ci

test: build
install/CI/test

Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ require (
go.uber.org/zap v1.12.0 // indirect
golang.org/x/crypto v0.0.0-20190510104115-cbcb75029529
golang.org/x/time v0.0.0-20191024005414-555d28b269f0 // indirect
google.golang.org/appengine v1.4.0 // indirect
google.golang.org/grpc v1.24.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't go.mod if there is no change of go code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have restore it

gopkg.in/ini.v1 v1.50.0 // indirect
gopkg.in/yaml.v2 v2.2.3
Expand Down
Loading