Post Release:Fix for beego framework issue #1169 #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1168 +/- ##
============================================
Coverage 34.82% 34.82%
============================================
Files 97 97
Lines 17622 17622
============================================
Hits 6137 6137
Misses 10614 10614
Partials 871 871 |
|
Few basic testing after beego version fix.
|
|
Fix for this issue, #1169 |
skdwriting
changed the title
skdwriting
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There is failure in CI.
fatal: Authentication failed for 'https://github.com/belogik/goes/'
The reason is: beego usses '/belogik/goes/' repo internally in verion v1.11.1, now that repo has been deleted so our build is failing. (#1169 )
In latest beego V1.12.0, this issue is handled and merged. Below is the link:
https://github.com/astaxie/beego/pull/3468/files
So we need updated version of beego, i.e V1.12.0
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: