Decouple api-server from controller framework #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
|
please fix the CI error. |
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
|
Currently this PR has passed unit test and integration test, @xxwjj please take a look at it and update |
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
leonwanghui
changed the title
leonwanghui
added
the
feature
leonwanghui
changed the title
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
|
Hi @xing-yang @wisererik , please take a review at this patch, thanks! |
xing-yang
reviewed
Jan 18, 2019
| // NOTE:The real volume group deletion process. | ||
| // Volume group deletion request is sent to the Dock. Dock will remove | ||
| // volume group record after volume group deletion operation is completed. | ||
| if err = v.CtrClient.Connect(CONF.OsdsLet.ApiEndpoint); err != nil { |
There was a problem hiding this comment.
We should let controller update the database, not Dock.
There was a problem hiding this comment.
Ok, I will update the code in next PR.
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
|
@xing-yang Please take a look at this patch, thanks! |
|
I will merge this patch for now, and start the second step of design proposal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See design spec for detailed information.
Please notice that this PR would address
Phase 1of the design spec.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
@xing-yang @wisererik Please take a review at this PR, thanks!
Release note: