Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devsds syntax error #610

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Fix devsds syntax error #610

merged 2 commits into from
Feb 7, 2019

Conversation

hirokikmr
Copy link
Contributor

What this PR does / why we need it:
Fix devsds uninstall script syntax error.

+ osds::keystone::uninstall
+ '[' true '!=' 'false]'
/root/gopath/src/github.com/opensds/opensds/script/devsds/lib/keystone.sh: line 158: [: missing `]'

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

fixes #609

Special notes for your reviewer:

Release note:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.659% when pulling b03a7b8 on hirokikmr:development-bug-fix into 266321d on opensds:development.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.659% when pulling b03a7b8 on hirokikmr:development-bug-fix into 266321d on opensds:development.

@coveralls
Copy link

coveralls commented Feb 6, 2019

Coverage Status

Coverage remained the same at 41.659% when pulling a248046 on hirokikmr:development-bug-fix into 266321d on opensds:development.

@xing-yang
Copy link
Collaborator

@hirokikmr Thanks for the fix!

@xing-yang
Copy link
Collaborator

lgtm

@xing-yang xing-yang merged commit 564afc8 into sodafoundation:development Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants