Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pwd encrypter #612

Merged
merged 13 commits into from
Feb 14, 2019
Merged

Pwd encrypter #612

merged 13 commits into from
Feb 14, 2019

Conversation

jackhaibo
Copy link
Contributor

What this PR does / why we need it:
Fix parsing yaml file bug in pwdEncrypter.go.

@coveralls
Copy link

coveralls commented Feb 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 39.94% when pulling 11496d1 on jackhaibo:pwd_encrypter into 21d324f on opensds:development.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.278% when pulling c6e30a9 on jackhaibo:pwd_encrypter into 0c6954e on opensds:development.

xxwjj
xxwjj reviewed Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@xxwjj xxwjj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/pwdEncrypter.go/pwdencypter.go
The file name should not contain upper case character.

leonwanghui
leonwanghui requested changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve @xxwjj comment.

@leonwanghui leonwanghui added the patch there is minor code change label Feb 14, 2019
@jackhaibo
Copy link
Contributor Author

s/pwdEncrypter.go/pwdencypter.go
The file name should not contain upper case character.

Already modified.

leonwanghui
leonwanghui approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit 3acb0c2 into sodafoundation:development Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxwjj xxwjj xxwjj left review comments

@leonwanghui leonwanghui leonwanghui approved these changes

Assignees

@jackhaibo jackhaibo

Labels
patch there is minor code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackhaibo @coveralls @xxwjj @leonwanghui