Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apiserver decouple] Second part #614

Merged
merged 35 commits into from
Mar 18, 2019
Merged

[Apiserver decouple] Second part #614

merged 35 commits into from
Mar 18, 2019

Conversation

leonwanghui
Copy link
Collaborator

What this PR does / why we need it:
See design spec for detailed information.
Please notice that this PR would address Phase 2 of the design spec.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@leonwanghui leonwanghui added the feature there is a huge framework change or feature addition label Feb 15, 2019
@leonwanghui leonwanghui self-assigned this Feb 15, 2019
@coveralls
Copy link

coveralls commented Feb 18, 2019

Coverage Status

Coverage increased (+0.9%) to 38.081% when pulling 398148f on leonwanghui:second-part into 3a29829 on opensds:development.

@leonwanghui
Copy link
Collaborator Author

This patch contains quite big changes with below items:

  • Merge controller and dock protobuf definition into model protobuf located in model module.
  • Move all logic about status machine into controller module, except that some database operations when deleting volume group still remains in dock module.
  • Change CreateAttachmentOpts and UpdateAttachmentOpts definition in protobuf to CreateVolumeAttachmentOpts and UpdateVolumeAttachmentOpts.
  • Make some changes of volume group operations with dock driver interface, to make it more standard.
  • Create pkg/model/proto/response.go file for Generating GenericResponse struct easily.
  • Add some status operations in pkg/db/db.go.
  • Simplify the ControllerGrpcServer construction by removing pkg/controller/server.go.
  • Update e2e_test.go to make e2e test output more elegant.

contrib/drivers/lvm/lvm.go Outdated Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
pkg/api/db.go Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
pkg/api/db.go Outdated Show resolved Hide resolved
@xing-yang
Copy link
Collaborator

@leonwanghui Can you address my comments, please? Also need a rebase.

@xing-yang
Copy link
Collaborator

@wisererik Please review this.

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik
Copy link
Collaborator

@leonwanghui please rebase your PR, thanks

Signed-off-by: leonwanghui <wanghui71leon@gmail.com>
@xing-yang
Copy link
Collaborator

LGTM

@xing-yang xing-yang merged commit 9e2b4d5 into sodafoundation:development Mar 18, 2019
@leonwanghui leonwanghui deleted the second-part branch July 9, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature there is a huge framework change or feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants