Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add NVMeoF support #632

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

qwren
Copy link
Contributor

@qwren qwren commented Mar 20, 2019

This patch will add NVMeoF support.

The NVMe over Fabrics (NVMeOF) is an emerging technology, and it gives
data centers unprecedented access to NVMe SSD storage. Like iSCSI, NVMeОF
is a network protocol used to communicate between a host and a storage
system over a network (aka fabric).

Signed-off-by: Shixin Yang shixin.yang@intel.com
Signed-off-by: Wenjie Liu wenjie.liu@intel.com
Signed-off-by: Qiaowei Ren qiaowei.ren@intel.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@leonwanghui leonwanghui added the feature there is a huge framework change or feature addition label Mar 20, 2019
@leonwanghui leonwanghui added this to the Capri Milestone-3 milestone Mar 20, 2019
contrib/connector/nvmeof/nvmeof_helper.go Outdated Show resolved Hide resolved
contrib/connector/nvmeof/nvmeof_helper.go Outdated Show resolved Hide resolved
contrib/drivers/lvm/lvm.go Outdated Show resolved Hide resolved
contrib/drivers/lvm/lvm.go Outdated Show resolved Hide resolved
contrib/drivers/lvm/targets/nvmeof.go Outdated Show resolved Hide resolved
script/devsds/lib/lvm.sh Outdated Show resolved Hide resolved
@xing-yang
Copy link
Collaborator

@qwren Thanks for contributing the NVMeoF driver? Can you submit your design specs to https://github.com/opensds/design-specs repo? I believe you have a draft already. Thanks.

@qwren
Copy link
Contributor Author

qwren commented Mar 21, 2019

@qwren Thanks for contributing the NVMeoF driver? Can you submit your design specs to https://github.com/opensds/design-specs repo? I believe you have a draft already. Thanks.

Sure, I am about to upstream that doc.

@qwren qwren force-pushed the nvmeof-support branch 2 times, most recently from 9e98707 to 42bbc8e Compare March 21, 2019 06:52
@coveralls
Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage decreased (-0.07%) to 37.948% when pulling b3c1855 on qwren:nvmeof-support into 770d820 on opensds:development.

@skdwriting
Copy link
Collaborator

/retest

@leonwanghui
Copy link
Collaborator

Also please rebase the code

This patch will add NVMeoF support.

The NVMe over Fabrics (NVMeOF) is an emerging technology, and it gives
data centers unprecedented access to NVMe SSD storage. Like iSCSI, NVMeОF
is a network protocol used to communicate between a host and a storage
system over a network (aka fabric).

Signed-off-by: Shixin Yang <shixin.yang@intel.com>
Signed-off-by: Wenjie Liu <wenjie.liu@intel.com>
Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
@wisererik
Copy link
Collaborator

LGTM

Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit ea275a7 into sodafoundation:development Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature there is a huge framework change or feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants