Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick Fujitsu driver to merge into stable/capri branch #942

Closed
wants to merge 3 commits into from

Conversation

leonwanghui
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
@xing-yang PTAL

Release note:

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #942 into stable/capri will increase coverage by 2.2%.
The diff coverage is 63.66%.

@@              Coverage Diff               @@
##           stable/capri    #942     +/-   ##
==============================================
+ Coverage          31.2%   33.4%   +2.2%     
==============================================
  Files                82      85      +3     
  Lines             15216   16325   +1109     
==============================================
+ Hits               4748    5454    +706     
- Misses             9764   10091    +327     
- Partials            704     780     +76
Impacted Files Coverage Δ
contrib/drivers/drivers.go 28.37% <0%> (-2.06%) ⬇️
contrib/drivers/fujitsu/eternus/common.go 100% <100%> (ø)
contrib/drivers/fujitsu/eternus/eternus.go 49.37% <49.37%> (ø)
contrib/drivers/fujitsu/eternus/client.go 70.5% <70.5%> (ø)

@leonwanghui
Copy link
Collaborator Author

Close it due to duplicated with #943

@leonwanghui leonwanghui closed this Jul 4, 2019
@xing-yang
Copy link
Collaborator

@leonwanghui by the way, this should only cherry pick the first two original commits, not the third merge commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants