Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow two profiles have same name #988

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

ThisIsClark
Copy link
Contributor

What this PR does / why we need it:
Profile's name should be unique, so check that whether the profile name is unique before creating a new profile.

Which issue this PR fixes :
fixes #987

Special notes for your reviewer:

Release note:

pkg/db/drivers/etcd/etcd.go Outdated Show resolved Hide resolved
pkg/db/drivers/etcd/etcd.go Show resolved Hide resolved
pkg/db/drivers/etcd/etcd.go Outdated Show resolved Hide resolved
pkg/db/drivers/etcd/etcd.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxwjj xxwjj requested review from kumarashit, xxwjj, leonwanghui and wisererik and removed request for leonwanghui August 26, 2019 06:02
Copy link
Collaborator

@xxwjj xxwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxwjj xxwjj merged commit 3bcecde into sodafoundation:master Aug 26, 2019
ThisIsClark added a commit to ThisIsClark/opensds that referenced this pull request Aug 26, 2019
Merge pull request sodafoundation#988 from ThisIsClark/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile's name should be unique
4 participants