Historic performance collection when last runtime not set #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushanthakumar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 70.43% 70.39% -0.04%
==========================================
Files 163 163
Lines 15855 15867 +12
Branches 1961 1962 +1
==========================================
+ Hits 11167 11170 +3
- Misses 4014 4021 +7
- Partials 674 676 +2
|
|
@NajmudheenCT @joseph-v @ThisIsClark Pls help to review this PR |
| self.task_id) | ||
| try: | ||
| telemetry = PerformanceCollectionTask() | ||
| telemetry.collect(self.ctx, self.storage_id, self.args, |
There was a problem hiding this comment.
return status can be captured and logged !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Issue description:
When new storage is added, performance collection is scheduled after adding job to scheduler with last run time as None.
It is possible that just before the collection cycle is triggered, task process can restart.
During restart, history collection is performed only if last run time is set. In this case, since restart happened before the completion of first collection, last run time is still not set. so we will end up not collecting the first part of performance metric.
Proposed solution:
During the task process restart, if last runtime is not set but job id is already generated, one historic collection can be done for the storage considering its collection interval time
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Test scenarios verified:
Release note: